Skip to content

chore: Use vscode-uri - #252

Merged
coliff merged 1 commit into
mainfrom
58-replace-uritofilepath-with-vscode-uri
Jun 13, 2025
Merged

chore: Use vscode-uri#252
coliff merged 1 commit into
mainfrom
58-replace-uritofilepath-with-vscode-uri

Conversation

@coliff

@coliff coliff commented Jun 13, 2025

Copy link
Copy Markdown
Member

Fixes: #58

These changes are much cleaner and more reliable now. The vscode-uri package handles all the edge cases for us, including:

  • Proper URI parsing
  • URL decoding
  • Platform-specific path handling
  • Proper handling of file:// protocol

@coliff coliff linked an issue Jun 13, 2025 that may be closed by this pull request

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively replaces manual URI parsing logic with the vscode-uri package in the HTMLHint server. This is a positive change that simplifies the codebase, enhances reliability by leveraging a well-tested library for URI manipulation, and improves maintainability.

The core changes in htmlhint-server/src/server.ts are clean and correctly implement the vscode-uri usage. The dependency updates in htmlhint-server/package.json and htmlhint-server/package-lock.json are appropriate.

One area for consideration is in htmlhint/package.json, specifically ensuring vscode-uri is consistently declared for bundling, as noted in the specific comment. Overall, this PR is a good step towards modernizing and stabilizing the URI handling in the extension.

Comment thread htmlhint/package.json
@coliff
coliff merged commit ee534a8 into main Jun 13, 2025
@coliff
coliff deleted the 58-replace-uritofilepath-with-vscode-uri branch June 13, 2025 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace uriToFilePath with vscode-uri

1 participant