chore: Use vscode-uri - #252
Conversation
There was a problem hiding this comment.
Code Review
This pull request effectively replaces manual URI parsing logic with the vscode-uri package in the HTMLHint server. This is a positive change that simplifies the codebase, enhances reliability by leveraging a well-tested library for URI manipulation, and improves maintainability.
The core changes in htmlhint-server/src/server.ts are clean and correctly implement the vscode-uri usage. The dependency updates in htmlhint-server/package.json and htmlhint-server/package-lock.json are appropriate.
One area for consideration is in htmlhint/package.json, specifically ensuring vscode-uri is consistently declared for bundling, as noted in the specific comment. Overall, this PR is a good step towards modernizing and stabilizing the URI handling in the extension.
Fixes: #58
These changes are much cleaner and more reliable now. The vscode-uri package handles all the edge cases for us, including: