Add support for credentials requests #434
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@indexzero this is for dev purposes |
|
@senaev would you mind merging/rebasing master? |
# Conflicts: # README.md # bin/http-server # lib/http-server.js
@indexzero @thornjad done |
thornjad
requested changes
Apr 19, 2019
test/http-server-test.js
Outdated
| credentials: true, | ||
| corsHeaders: 'X-Test' | ||
| }); | ||
| server.listen(8083); |
There was a problem hiding this comment.
This port is already being used by username/password tests, so we should do 8085 here (8084 is also claimed). This is causing the tests to fail.
senaev
commented
Apr 19, 2019
test/http-server-test.js
Outdated
| credentials: true, | ||
| corsHeaders: 'X-Test' | ||
| }); | ||
| server.listen(8083); |
|
@thornjad check this please |
|
This pull request has been inactive for 360 days |
thornjad
requested changes
Oct 12, 2021
Comment on lines
+34
to
+35
| ' --credentials Cookie credentials can be transferred as part of a CORS request', | ||
| ' Enables --cors automatically', |
There was a problem hiding this comment.
I'm concerned that the name of this switch is too general for its use case, how would you feel about --cookie-credentials or shorten to --cookie-creds or something like that?
thornjad
added
minor version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To serve files with credentials support cross domains we ned to not just add some headers in request, we should also change Access-Control-Allow-Origin header to Origin value from request.
I added a new flag for it, because is is different from --cors logic and may be not safe for users.