-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --no-verbose CLI option #538
base: master
Are you sure you want to change the base?
Conversation
silent but show the basic info
I'm not sure of the usefulness of this option. The info is already shown by default, and will be the only output before any requests are made (providing the clickable link in some terminal emulators, as mentioned in the linked issues). And then there is already |
The use-case is this: spawning a dev server for folks in scaffolded projects, many developers don't know what port However, verbose request logging for a development server is not workable: it interlaces request logs with far more important information, like build information and errors. There are many cases where request logging is unnecessary, yet where the display of a server's listen() address is still important. |
For use in scaffolding, would it be sufficient to have the scaffold pass a predetermined port into http-server and tell the user that port? |
This pull request has been inactive for 360 days |
I think I've come round on this change, and I'm down to review it, but a few things first:
|
Please ensure that your pull request fulfills these requirements:
master
branchWhat is the purpose of this pull request? (bug fix, enhancement, new feature,...)
Add a option to prevent showing all the request info, but show the basic info.
fixes #532
fixes #381
What changes did you make?
Add --no-verbose option
Provide some example code that this change will affect, if applicable:
N/A