Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --no-verbose CLI option #538

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Xmader
Copy link
Contributor

@Xmader Xmader commented Jun 5, 2019

Please ensure that your pull request fulfills these requirements:

  • The pull request is being made against the master branch
  • Tests for the changes have been added (for bug fixes / features)

What is the purpose of this pull request? (bug fix, enhancement, new feature,...)

Add a option to prevent showing all the request info, but show the basic info.

fixes #532

fixes #381

What changes did you make?

Add --no-verbose option

Provide some example code that this change will affect, if applicable:

N/A

Xmader added 2 commits June 4, 2019 23:40
@Xmader Xmader changed the title add a option of no verbose Add --no-verbose CLI option Nov 26, 2019
@thornjad
Copy link
Member

I'm not sure of the usefulness of this option. The info is already shown by default, and will be the only output before any requests are made (providing the clickable link in some terminal emulators, as mentioned in the linked issues). And then there is already --silent to suppress all logging. What is the additional benefit of this "sort-of-silent" option?

@developit
Copy link

The use-case is this: spawning a dev server for folks in scaffolded projects, many developers don't know what port http-server was spawned on (especially if it auto-selected a free port). That makes the URL output immensely valuable, since otherwise you have to know that the default is 8080 and it uses an incrementing search to find free ports.

However, verbose request logging for a development server is not workable: it interlaces request logs with far more important information, like build information and errors. There are many cases where request logging is unnecessary, yet where the display of a server's listen() address is still important.

@thornjad
Copy link
Member

thornjad commented Apr 6, 2020

For use in scaffolding, would it be sufficient to have the scaffold pass a predetermined port into http-server and tell the user that port?

@github-actions
Copy link

This pull request has been inactive for 360 days

@github-actions github-actions bot added the stale label Aug 21, 2021
@thornjad
Copy link
Member

I think I've come round on this change, and I'm down to review it, but a few things first:

  • fix merge conflicts and merge master
  • add documentation:
    • --help output
    • README.md
    • doc/http-server.1

@thornjad thornjad added minor version non-breaking, non-trivial change feature and removed stale labels Oct 12, 2021
@thornjad thornjad mentioned this pull request Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature minor version non-breaking, non-trivial change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Silent but shown initial output why -slient doesn't show the basic info
3 participants