Add option for ssl ca file #735
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thornjad
requested changes
Oct 5, 2021
| @@ -48,6 +48,7 @@ if (argv.h || argv.help) { | |||
| ' -S --ssl Enable https.', | |||
| ' -C --cert Path to ssl cert file (default: cert.pem).', | |||
| ' -K --key Path to ssl key file (default: key.pem).', | |||
| ' -A --ca Path to ssl ca file (default: ca.pem).', | |||
There was a problem hiding this comment.
I'm unsure about how intuitive -A is. How would you feel about --ca being the only option, with no short option for this?
|
This pull request has been inactive for 360 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the http-server with SSL enabled, there was no command line option to configure the CA file. I added this option.
Fixes #155