Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for ssl ca file #735

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

mpanne
Copy link

@mpanne mpanne commented Oct 1, 2021

When running the http-server with SSL enabled, there was no command line option to configure the CA file. I added this option.

Fixes #155

@mpanne mpanne changed the title Add option for ssl ca file. Add option for ssl ca file Oct 1, 2021
@thornjad thornjad added the minor version non-breaking, non-trivial change label Oct 5, 2021
Copy link
Member

@thornjad thornjad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love how simple this is! Besides my question below, we still need to add in:

  • tests
  • documentation in README.md
  • documentation in doc/http-server.1

@@ -48,6 +48,7 @@ if (argv.h || argv.help) {
' -S --ssl Enable https.',
' -C --cert Path to ssl cert file (default: cert.pem).',
' -K --key Path to ssl key file (default: key.pem).',
' -A --ca Path to ssl ca file (default: ca.pem).',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure about how intuitive -A is. How would you feel about --ca being the only option, with no short option for this?

@github-actions
Copy link

github-actions bot commented Oct 9, 2022

This pull request has been inactive for 360 days

@github-actions github-actions bot added the stale label Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature minor version non-breaking, non-trivial change stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for CA bundles?
2 participants