Skip to content

Just a sprinkle of accessibility #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Timmaaaa wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Just a sprinkle of accessibility #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c35599
accessibility-basic-0
Timmaaaa Oct 1, 2022
fc0be95
footer
Timmaaaa Oct 1, 2022
ad9bbbd
Update Footer.js
Timmaaaa Oct 1, 2022
c9a1ac4
Delete Footer.js
Timmaaaa Oct 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/components/Footer/Footer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import getString from '../../lib/strings'
import styles from './Footer.module.css'

const Footer = () => (
<div className={styles.container}>
<footer className={styles.container}>
<div className={styles.social}>
<FacebookButton />
<GithubButton />
Expand All @@ -21,8 +21,8 @@ const Footer = () => (
<p>{getString('DEVELOPED_BY')} <a href="https://twitter.com/rogeriopvl">@rogeriopvl</a></p>
<p>{getString('IMAGES_BY')} Tomomi Imura (<a href="https://twitter.com/girlie_mac">@girlie_mac</a>)</p>

<p>Check out <a href='https://www.abstractapi.com'>Abstract API</a>, the home for modern, developer-friendly tools like the <a href='https://www.abstractapi.com/ip-geolocation-api'>IP Geolocation API</a>, <a href='https://www.abstractapi.com/vat-validation-rates-api'>VAT Validation & Rates API</a>, <a href='https://www.abstractapi.com/holidays-api'>Public Holiday API</a>, and more.</p>
</div>
<p>Check out <a href='https://www.abstractapi.com'>Abstract API</a>, the home for modern, developer-friendly tools like the <a href='https://www.abstractapi.com/ip-geolocation-api'>IP Geolocation API</a>, <a href='https://www.abstractapi.com/vat-validation-rates-api'>VAT Validation & Rates API</a>, <a href='https://www.abstractapi.com/holidays-api'>Public Holiday API</a>, and more.</p>
</footer>
)

export default Footer
6 changes: 3 additions & 3 deletions src/components/Header/Header.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ import styles from './Header.module.css'

const Header = () => (
<header className={styles.container}>
<a href="/" className={styles.link}>
<div className={styles.logo}>
<a href="/" className={styles.link} aria-labelledby="headerTitle" >
<div className={styles.logo} tabIndex="-1" aria-hidden >
<Logo width="80" height="55" color="#d0383e" />
</div>
<h1 className={styles.title}>
<h1 id="headerTitle" className={styles.title} aria-level="1">
{getString('APP_TITLE')}
</h1>
</a>
Expand Down
6 changes: 3 additions & 3 deletions src/components/Thumbnail/Thumbnail.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@ import styles from './Thumbnail.module.css'

const Thumbnail = ({ code, description }) => (
<div className={styles.container}>
<a href={`/${code}`}>
<a href={`/${code}`} aria-labelledby="thumbnailDescription">
<div
className={styles.image}
className={styles.image} aria-hidden
style={{ backgroundImage: `url(/images/${code}.jpg)` }}
/>
<div className={styles.content}>
<div id="thumbnailDescription" className={styles.content}>
<div className={styles.title}>{code}</div>
<p>{description}</p>
</div>
Expand Down
10 changes: 5 additions & 5 deletions src/components/Usage/Usage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,20 +25,20 @@ const Usage = () => {
}, [isValueCopied])

return (
<div className={styles.container}>
<h2>{getString('USAGE_TITLE')}:</h2>
<section className={styles.container} aria-labelledby="usageTitle" >
<h2 id="usageTitle" aria-level="2">{getString('USAGE_TITLE')}:</h2>
<pre>
{usageValue}
{'clipboard' in navigator && (
<button onClick={copyValue} title='Copy to clipboard'>
{isValueCopied ? getString('COPIED') : <img src={copyIcon} alt={getString('COPY_ICON_ALT_TEXT')} />}
{isValueCopied ? getString('COPIED') : <img src={copyIcon} alt={getString('COPY_ICON_ALT_TEXT')} aria-hidden />}
</button>
)}
</pre>
<p>
<b>{getString('USAGE_NOTE_LABEL')}:</b> {getString('USAGE_NOTE_TEXT')}{' '}<code>.jpg</code>.
<b>{getString('USAGE_NOTE_LABEL') + ': '}</b>{getString('USAGE_NOTE_TEXT') + ' '}<code>.jpg</code>.
</p>
</div>
</section>
)
}

Expand Down