fix: ensure Content-Type is set when sending JSON with custom headers#1840
Closed
zafar1162014 wants to merge 1 commit intohttpie:masterfrom
Closed
fix: ensure Content-Type is set when sending JSON with custom headers#1840zafar1162014 wants to merge 1 commit intohttpie:masterfrom
zafar1162014 wants to merge 1 commit intohttpie:masterfrom
Conversation
When custom headers are provided alongside JSON data, the Content-Type header should still be set to application/json. Previously, if only a single custom header was provided, the Content-Type was not being set, causing issues with some API gateways that auto-encode request bodies when Content-Type is missing. Fixes #1834
There was a problem hiding this comment.
Pull request overview
This PR aims to fix HTTPie’s JSON request header handling so Content-Type: application/json is preserved when users send JSON data together with custom headers, addressing issue #1834 around API gateways mis-handling bodies when the header is missing.
Changes:
- Updates request header construction in
make_request_kwargs()to explicitly setContent-Typefor auto-JSON requests after merging base and user-provided headers. - Adds inline documentation referencing the reported regression and intended behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+347
to
+352
| # Ensure Content-Type is set for JSON requests even if user headers | ||
| # were provided. This fixes the case where a single custom header | ||
| # prevents the default Content-Type from being preserved. | ||
| # See: https://github.com/httpie/cli/issues/1834 | ||
| if auto_json and 'Content-Type' not in headers: | ||
| headers['Content-Type'] = JSON_CONTENT_TYPE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When custom headers are provided alongside JSON data, the Content-Type header should still be set to application/json. Previously, if only a single custom header was provided, the Content-Type was not being set, causing issues with some API gateways that auto-encode request bodies when Content-Type is missing.
Fixes #1834