feat: add Opera GX and Opera Crypto #16
Merged
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pimterry
reviewed
Jun 19, 2023
|
Would be nice to bump the Windows dependency with this, but I'm not sure how long it'll take for that to get reviewed & shipped, and it looks like this is usable for Mac even without that, right? If so I'm happy to merge to get Mac support only, and add Windows support with a dependency update later on once that's available. |
nsrCodes
force-pushed
the
add-other-opera-browsers
branch
from
15abead to
700d700
Compare
|
@pimterry I have updated the PR, no extra commits, so can be merged without squashing. And yes, this can be released without waiting for the other PR. Although would be nice to get these changes for Windows too, that's mainly where these browsers are more popular. but one can only wait 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows
Supporting PR in win-detect-browers - vweevers/win-detect-browsers#83
Linux
Opera only distributes the original opera on Linux, not Opera GX or Opera Crypto. Hence did not add the
platformattribute so that at least one of the three variants can still be detectedMacOS
Tested on MacOS, Ventura 13.4
Works as expected.