Skip to content

Add signature verification metadata and policy controls - #1

Merged
huanfeng merged 1 commit into
mainfrom
codex/add-signature-metadata-to-export-process
Dec 13, 2025
Merged

Add signature verification metadata and policy controls#1
huanfeng merged 1 commit into
mainfrom
codex/add-signature-metadata-to-export-process

Conversation

@huanfeng

Copy link
Copy Markdown
Owner

Summary

  • add manifest signature metadata and signing configuration to repository manifests
  • enhance bucket and repository commands with signature verification flags and trust policy handling
  • verify APK hashes/signatures during repository validation with configurable strict/lenient behavior

Testing

  • go test ./...

Codex Task

@huanfeng
huanfeng merged commit 69874a5 into main Dec 13, 2025
2 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread cmd/verify.go
Comment on lines +350 to +352
localPath, hasLocalPath := resolveLocalAPKPath(version.DownloadURL)
if !hasLocalPath {
continue

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Skipping APK verification for http/https download URLs

The new APK validation loop now immediately continues when resolveLocalAPKPath returns false (i.e., for any download URL starting with http/https). For repositories configured with a BaseURL that produces absolute download URLs, every APK will hit this branch, so checkAPKFiles skips existence/hash checks, leaves ValidFiles at 0, and still reports “no issues”. This regression means apkhub verify no longer detects missing or corrupted APKs for the common case of remote BaseURLs.

Useful? React with 👍 / 👎.

@huanfeng
huanfeng deleted the codex/add-signature-metadata-to-export-process branch December 16, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant