fix(plugin): end span in afterReponse hook (#10)

huang-julien · Jan 16, 2025 · 4a18d50 · 4a18d50
1 parent 88b6456
commit 4a18d50
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/src/runtime/plugin.ts b/src/runtime/plugin.ts
@@ -29,12 +29,17 @@ export default <NitroAppPlugin>((nitro) => {
         }, parentCtx)
         trace.setSpan(context.active(), span)
         event.context.span = span
+        event.context.__otel = {}
     })
 
-    nitro.hooks.hook('beforeResponse', async (event) => {
+    nitro.hooks.hook('beforeResponse', (event) => {
+        event.context.__otel.endTime = Date.now()
+    })
+
+    nitro.hooks.hook('afterResponse', async (event) => {
         event.context.span.setAttribute(ATTR_HTTP_RESPONSE_STATUS_CODE, getResponseStatus(event))
         await nitro.hooks.callHook('otel:span:end', { event, span: event.context.span })
-        event.context.span.end()
+        event.context.span.end(event.context.__otel.endTime) 
     })
 
     nitro.hooks.hook('error', (error, { event }) => {