refactor(control-plane): render bootstrap steps through effect program - #2955
Merged
Conversation
huangruiteng
commented
Aug 8, 2026
huangruiteng
left a comment
Owner
Author
There was a problem hiding this comment.
Approval conclusion (author-owned PR; GitHub blocks formal self-approval)
Reviewed exact head 6543ad5. No blocking findings.
The PR makes the bootstrap guided-render path consume EffectProgram while
preserving raw step details for capability guards. Public output unchanged.
Validation
python -m pytest tests/control_plane/test_effect_program_ordered_steps.py tests/control_plane/test_start_goal_compact_projection.py: 34 passed.examples/bootstrap-command-pack-smoke.py, CLI output budget, and hot-path
interface budget: passed.loopx canary premerge --from-git-diff: passed,self_merge_allowed=true,
0 manual holds.- GitHub pytest, build, and dependency-review on this head: pass.
- Public boundary scan: passed.
Merge decision: approved after reviewer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
R1 replacement-first change: bootstrap guided rendering now consumes
EffectProgram.effect_program_from_ordered_stepsnow retains the raw step mapping onEffectStep.raw.render_start_goal_guided_markdownreadsguided_transaction.ordered_stepsthrough
EffectPrograminstead of iterating raw dicts directly.No public CLI/packet behavior changes.
Validation
python -m pytest tests/control_plane/test_effect_program_ordered_steps.py tests/control_plane/test_start_goal_compact_projection.py: 34 passed.examples/bootstrap-command-pack-smoke.py: passed.cli-output-budget-regression-smokeandhot-path-interface-budget-smoke: passed.loopx canary premerge --from-git-diff: passed,self_merge_allowed=true,0 manual holds.
Routing
independent_handoffcodex-quality-qualificationcodex-side-bypass