refactor(control-plane): resolve turn result kind through effect turn - #2956
Merged
Conversation
huangruiteng
commented
Aug 8, 2026
huangruiteng
left a comment
Owner
Author
There was a problem hiding this comment.
Approval conclusion (author-owned PR; GitHub blocks formal self-approval)
Reviewed exact head 9b59876. No blocking findings.
The PR routes the turn executor's task-validation result-kind resolution
through interpret_turn_result_packet, replacing direct dict access in a real
runtime path. Public behavior unchanged.
Validation
python -m pytest tests/test_loopx_turn_executor.py tests/control_plane/test_effect_turn_turn_result.py: 20 passed.examples/loopx-turn-fake-host-walkthrough-smoke.py, CLI output budget, and
control-plane risk characterization: passed.loopx canary premerge --from-git-diff: passed,self_merge_allowed=true,
0 manual holds.- GitHub pytest, build, and dependency-review on this head: pass.
- Public boundary scan: passed.
Merge decision: approved after reviewer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
R2 replacement-first change: turn executor resolves result kind through
EffectTurn._task_validation_stagenow readsinterpret_turn_result_packet(...)toderive
LoopXTurnResultKind, replacing directresult["result_kind"]access in the real turn-driver runtime path.
effect turn lens.
No public behavior changes.
Validation
python -m pytest tests/test_loopx_turn_executor.py tests/control_plane/test_effect_turn_turn_result.py: 20 passed.examples/loopx-turn-fake-host-walkthrough-smoke.py: passed.cli-output-budget-regression-smokeandcontrol-plane-risk-characterization-smoke: passed.loopx canary premerge --from-git-diff: passed,self_merge_allowed=true,0 manual holds.
Routing
independent_handoffcodex-quality-qualificationcodex-side-bypass