refactor(status): move benchmark status compaction into bounded read models - #2978
Merged
Merged
Conversation
huangruiteng
commented
Aug 9, 2026
huangruiteng
left a comment
Owner
Author
There was a problem hiding this comment.
Review: APPROVED
head ad3f0686a。这是对 PR #2978 的完整 owner review。该 PR 是 M6 Q4 的 benchmark-sensitive 收尾片:benchmark status compaction 从 loopx/status.py 迁入两个 bounded benchmark read-model 模块,loopx/status.py 降到 1392 行并保留薄兼容壳与 audited reexport。
验证
- 全量 pytest:
2306 passed, 2 skipped - 聚焦 benchmark/status/import-boundary/maintainability:
45 passed - ruff:通过
loopx canary premerge --from-git-diff:selected 17 checks passed;唯一benchmark_sensitivemanual hold 由本 owner review 覆盖- 两个 benchmark-run-ledger smoke 在干净
origin/main上也失败,与本 PR 无关 - GitHub checks:dependency-review / pytest / build 全部通过
结论
无 blocker。benchmark status compaction 现在位于 bounded benchmark read-models,公共 facade 行为保持。按仓库 merge policy 路由合并。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Q4 benchmark-sensitive completion slice: the benchmark status compaction block moves out of
loopx/status.pyinto two bounded benchmark read-model modules:loopx/benchmarks/read_models/benchmark_status_compaction.pyloopx/benchmarks/read_models/benchmark_status_runner.pyloopx.statusnow keeps thin compatibility wrappers forcompact_benchmark_run,compact_benchmark_post_launch_materialization, and the private post-launch materialization helper.loopx/status.pydrops from 2924 lines to 1392 lines, satisfying the M6 status.py < 2000 gate.The
build_skillsbench_post_run_debug_gatereexport is preserved as an audited compatibility entry with explicit test evidence.Surfaces
loopx/benchmarks/read_models/benchmark_status_compaction.pyloopx/benchmarks/read_models/benchmark_status_runner.pyloopx/status.pytests/benchmarks/read_models/test_skillsbench_post_run_debug.pyValidation
2306 passed, 2 skipped.45 passed.All checks passed.loopx canary premerge --from-git-diff: selected 17 checks passed; onebenchmark_sensitivemanual hold is resolved by this owner review.origin/main; they are pre-existing and unrelated to this PR.No new failures or skips beyond the pre-existing suite. No manual holds after owner review.
Routing
Route:
codex-side-bypass; not assigned tocodex-quality-qualification.