Skip to content

refactor: remove obsolete ovni-based TraCR instrumentation hooks #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
noabauma wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

refactor: remove obsolete ovni-based TraCR instrumentation hooks #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions include/hicr/backends/nosv/executionState.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,6 @@
#include <hicr/backends/nosv/executionUnit.hpp>
#include <hicr/backends/nosv/common.hpp>

#ifdef ENABLE_INSTRUMENTATION
#include <tracr.hpp>
#endif

namespace HiCR::backend::nosv
{

Expand Down Expand Up @@ -159,11 +155,6 @@ class ExecutionState final : public HiCR::ExecutionState

auto metadata = (taskMetadata_t *)getTaskMetadata(self_task);

// TraCR set trace of thread polling again (as it suspended his task)
#ifdef ENABLE_INSTRUMENTATION
INSTRUMENTATION_THREAD_MARK_SET((long)2);
#endif

// Resume the parent task to continue running other tasks.
check(nosv_submit(metadata->parent_task, NOSV_SUBMIT_NONE));

Expand All @@ -185,11 +176,6 @@ class ExecutionState final : public HiCR::ExecutionState
*/
static __INLINE__ void run_callback(nosv_task_t task)
{
// TraCR set trace of thread executing a task
#ifdef ENABLE_INSTRUMENTATION
INSTRUMENTATION_THREAD_MARK_SET((long)0);
#endif

// Accessing metadata from the task
auto metadata = (taskMetadata_t *)getTaskMetadata(task);

Expand All @@ -205,11 +191,6 @@ class ExecutionState final : public HiCR::ExecutionState
// Executing the function (Else we throw at runtime)
if (fc) { fc(arg); }
else { HICR_THROW_RUNTIME("Error: No valid callback function.\n"); }

// TraCR reset marker to nothing as otherwise nOS-V continues displaying them.
#ifdef ENABLE_INSTRUMENTATION
INSTRUMENTATION_VMARKER_RESET();
#endif
}

/**
Expand Down
14 changes: 0 additions & 14 deletions include/hicr/frontends/tasking/task.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,6 @@
#include "callbackMap.hpp"
#include "common.hpp"

#ifdef ENABLE_INSTRUMENTATION
#include <tracr.hpp>
#endif

namespace HiCR::tasking
{

Expand Down Expand Up @@ -178,19 +174,9 @@ class Task
// Triggering execution callback, if defined
if (_callbackMap != nullptr) _callbackMap->trigger(this, callback_t::onTaskExecute);

// TraCR set trace of thread executing a task
#ifdef ENABLE_INSTRUMENTATION
INSTRUMENTATION_THREAD_MARK_SET((long)0);
#endif

// Now resuming the task's execution
_executionState->resume();

// TraCR set trace of thread polling again
#ifdef ENABLE_INSTRUMENTATION
INSTRUMENTATION_THREAD_MARK_SET((long)2);
#endif

// Checking execution state finalization
bool isFinished = _executionState->checkFinalization();

Expand Down
Loading