Skip to content

feat(css): add datasource elasticsearch enabled elb certificates #6430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(css): add datasource elasticsearch enabled elb certificates #6430

wants to merge 1 commit into from
+241 −17

Conversation

luoping-12345
Copy link
Contributor

@luoping-12345 luoping-12345 commented Feb 27, 2025 •
edited
Loading

What this PR does / why we need it:
add datasource elasticsearch enabled elb certificates

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

add datasource elasticsearch enabled elb certificates

PR Checklist

  • Tests added/passed.
make testacc TEST='./huaweicloud/services/acceptance/css' TESTARGS='-run TestAccDataSourceCssEsEnabledElbCertificates'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/css -v -run TestAccDataSourceCssEsEnabledElbCertificates -timeout 360m -parallel 4
=== RUN   TestAccDataSourceCssEsEnabledElbCertificates_basic
=== PAUSE TestAccDataSourceCssEsEnabledElbCertificates_basic
=== CONT  TestAccDataSourceCssEsEnabledElbCertificates_basic
--- PASS: TestAccDataSourceCssEsEnabledElbCertificates_basic (890.39s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/css       890.443s

  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@WangLiNaruto
Copy link

LGTM

1 similar comment
@profoundwu
Copy link
Contributor

LGTM

@houpeng80
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Feb 27, 2025
Jason-Zhang9309
Jason-Zhang9309 reviewed Mar 13, 2025
View reviewed changes
docs/data-sources/css_es_enabled_elb_certificates.md
Use this data source to get the list of CSS es cluster enabled certificates.
---

# huaweicloud_css_es_enabled_elb_certificates
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# huaweicloud_css_es_enabled_elb_certificates
# huaweicloud_css_elb_certificates

the data_source name is too long

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jason-Zhang9309 Jason-Zhang9309 Jason-Zhang9309 left review comments

Assignees
No one assigned
Labels
feature LGTM /lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@luoping-12345 @WangLiNaruto @profoundwu @houpeng80 @Jason-Zhang9309 @github-ci-robot