Skip to content

Conversation

@jinyangyang222
Copy link
Contributor

@jinyangyang222 jinyangyang222 commented Apr 2, 2025

What this PR does / why we need it:

refactor ims_evs_system_image resource code style

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Create a resource using the old code package:
image

Execute terraform plan using new code package:
image

In summary, it can be considered that this reconstruction will have no impact on existing users.

Release note:


refactor `ims_evs_system_image` resource code style

PR Checklist

  • Tests added/passed.
$ make testacc TEST="./huaweicloud/services/acceptance/ims" TESTARGS="-run TestAccEvsSystemImage_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/ims -v -run TestAccEvsSystemImage_basic -timeout 360m -parallel 4
=== RUN   TestAccEvsSystemImage_basic
=== PAUSE TestAccEvsSystemImage_basic
=== CONT  TestAccEvsSystemImage_basic
--- PASS: TestAccEvsSystemImage_basic (420.30s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/ims       420.379s

image

  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      image

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      image

@jinyangyang222 jinyangyang222 force-pushed the refactor-ims/refactor-evs_system-codeStyle branch from 04868af to c619dda Compare April 2, 2025 06:49
@deer-hang
Copy link
Contributor

/approve
/lgtm

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 3, 2025
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @deer-hang

Details

/approve
/lgtm

@github-ci-robot github-ci-robot merged commit 302dd54 into huaweicloud:master Apr 3, 2025
11 checks passed
@jinyangyang222 jinyangyang222 deleted the refactor-ims/refactor-evs_system-codeStyle branch July 24, 2025 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. LGTM /lgtm refactor size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants