Skip to content

feat(vpc): add new data_source secgroup tags#6611

Merged
github-ci-robot merged 1 commit intohuaweicloud:masterfrom
Jason-Zhang9309:dev-vpc-secgroup-tags
Apr 3, 2025
Merged

feat(vpc): add new data_source secgroup tags#6611
github-ci-robot merged 1 commit intohuaweicloud:masterfrom
Jason-Zhang9309:dev-vpc-secgroup-tags

Conversation

@Jason-Zhang9309
Copy link
Collaborator

What this PR does / why we need it:

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
make testacc TEST='./huaweicloud/services/acceptance/vpc' TESTARGS='-run TestAccDataSourceVpcNetworkingSecgroupTags_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/vpc -v -run TestAccDataSourceVpcNetworkingSecgroupTags_basic -timeout 360m -parallel 4
=== RUN   TestAccDataSourceVpcNetworkingSecgroupTags_basic
=== PAUSE TestAccDataSourceVpcNetworkingSecgroupTags_basic
=== CONT  TestAccDataSourceVpcNetworkingSecgroupTags_basic
--- PASS: TestAccDataSourceVpcNetworkingSecgroupTags_basic (37.96s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/vpc       38.006s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2025
@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @Jason-Zhang9309

@Jason-Zhang9309 Jason-Zhang9309 force-pushed the dev-vpc-secgroup-tags branch from 518da0f to f7b1750 Compare April 3, 2025 07:44
@github-actions github-actions bot added size/M and removed size/L labels Apr 3, 2025
@houpeng80
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Apr 3, 2025
@github-ci-robot github-ci-robot merged commit eb52b20 into huaweicloud:master Apr 3, 2025
13 checks passed
@Jason-Zhang9309 Jason-Zhang9309 deleted the dev-vpc-secgroup-tags branch April 3, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants