feat(agency): make v5 assume role duration configurable#6616
Merged
github-ci-robot merged 4 commits intohuaweicloud:masterfrom Apr 7, 2025
Merged
feat(agency): make v5 assume role duration configurable#6616github-ci-robot merged 4 commits intohuaweicloud:masterfrom
github-ci-robot merged 4 commits intohuaweicloud:masterfrom
Conversation
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This PR has been approved by: @niuzhenguo |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
huaweicloud/provider.go:2785
- It appears that 'delegatedDomianName' is misspelled. Consider renaming it to 'delegatedDomainName' for clarity.
delegatedDomianName := os.Getenv("HW_ASSUME_ROLE_DOMAIN_NAME")
| if delegatedDurationStr != "" { | ||
| var err error | ||
| delegatedDuration, err = strconv.Atoi(delegatedDurationStr) | ||
| if err != nil { |
There was a problem hiding this comment.
When conversion of HW_ASSUME_ROLE_DURATION fails, the code logs an error and defaults to 0. Consider adding validation or a more descriptive error handling approach if 0 is not an acceptable duration.
Collaborator
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes:
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)fixes #xxx
Special notes for your reviewer:
Release note:
PR Checklist
Documentation updated.
Schema updated.
CheckDeleted.
a. During query operation (Read Context)
aa. Resource not found
>>>>>> Paste the screenshot here <<<<<<
b. During delete/disassociate/unbind operation (Delete Context)
ba. Resource not found
>>>>>> Paste the screenshot here <<<<<<