Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ims): refactor ims_evs_data_image resource code style #6618

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jinyangyang222
Copy link
Contributor

@jinyangyang222 jinyangyang222 commented Apr 7, 2025

What this PR does / why we need it:

refactor ims_evs_data_image resource code style

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Create a resource using the old code package:
image

Execute terraform plan using new code package:
image

In summary, it can be considered that this reconstruction will have no impact on existing users.

Release note:


refactor `ims_evs_data_image` resource code style

PR Checklist

  • Tests added/passed.
$ make testacc TEST="./huaweicloud/services/acceptance/ims" TESTARGS="-run TestAccEvsDataImage_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/ims -v -run TestAccEvsDataImage_basic -timeout 360m -parallel 4
=== RUN   TestAccEvsDataImage_basic
=== PAUSE TestAccEvsDataImage_basic
=== CONT  TestAccEvsDataImage_basic
--- PASS: TestAccEvsDataImage_basic (411.16s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/ims       411.211s

image

  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      image

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant