Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(evs): refactor evs snapshot resource with general code style #6619

Merged

Conversation

deer-hang
Copy link
Contributor

@deer-hang deer-hang commented Apr 7, 2025

What this PR does / why we need it:

refactor evs snapshot resource with general code style
image

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
make testacc TEST='./huaweicloud/services/acceptance/evs' TESTARGS='-run TestAccEvsSnapshot_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/evs -v -run TestAccEvsSnapshot_basic -timeout 360m -parallel 4
=== RUN   TestAccEvsSnapshot_basic
=== PAUSE TestAccEvsSnapshot_basic
=== CONT  TestAccEvsSnapshot_basic
--- PASS: TestAccEvsSnapshot_basic (68.12s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/evs       68.174s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      image

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      image

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2025
@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @deer-hang

@deer-hang deer-hang force-pushed the refactor-evs-snapshot branch from a20098f to bf0ca2d Compare April 7, 2025 08:17
@jinyangyang222
Copy link
Contributor

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Apr 8, 2025
@github-ci-robot github-ci-robot merged commit 88eddbe into huaweicloud:master Apr 8, 2025
22 checks passed
@deer-hang deer-hang deleted the refactor-evs-snapshot branch April 8, 2025 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants