Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ELB): add params to elb loadbalancers data source #6623

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

houpeng80
Copy link
Collaborator

What this PR does / why we need it:
add params to elb loadbalancers data source
Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

  add params to elb loadbalancers data source

PR Checklist

  • Tests added/passed.
make testacc TEST=./huaweicloud/services/acceptance/elb/ TESTARGS='-run TestAccDatasourceLoadBalancers_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/elb/ -v -run TestAccDatasourceLoadBalancers_basic -timeout 360m -parallel 4
=== RUN   TestAccDatasourceLoadBalancers_basic
=== PAUSE TestAccDatasourceLoadBalancers_basic
=== CONT  TestAccDatasourceLoadBalancers_basic
--- PASS: TestAccDatasourceLoadBalancers_basic (523.61s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/elb       523.656s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2025
@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @houpeng80

@houpeng80 houpeng80 force-pushed the elb_loadbalancers_add_params branch from a706b16 to eb4a07f Compare April 7, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants