Skip to content

feat(lts/sql_alarm_rule): add new parameters and use 'notification_save_rule' instead of 'notification_rule' #6710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wuzhuanhong
Copy link
Contributor

What this PR does / why we need it:

  1. Use notification_save_rule instead of notification_rule parameter and send_notifications paramter supports modification.
  2. Add new parameters.
  • new paramster: alarm_action_rule_name, alarm_rule_alias, notification_frequency, sql_requests.log_group_name, sql_requests.log_stream_name.
  • The send_notifications parameter supports modify.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

add new parameters and use 'notification_save_rule' instead of 'notification_rule'.

PR Checklist

  • Tests added/passed.
make testacc TEST='./huaweicloud' TESTARGS='-run=TestAccSomethingV0_basic'
...
./scripts/coverage.sh -o lts -f TestAccSQLAlarmRule_basic
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/lts" -v -coverprofile="./huaweicloud/services/acceptance/lts/lts_coverage.cov" -coverpkg="./huaweicloud/services/lts" -run TestAccSQLAlarmRule_basic -timeout 360m -parallel 10
=== RUN   TestAccSQLAlarmRule_basic
=== PAUSE TestAccSQLAlarmRule_basic
=== CONT  TestAccSQLAlarmRule_basic
--- PASS: TestAccSQLAlarmRule_basic (62.75s)
PASS
coverage: 12.8% of statements in ./huaweicloud/services/lts
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/lts       62.876s coverage: 12.8% of statements in ./huaweicloud/services/lts

./scripts/coverage.sh -o lts -f TestAccKeywordsAlarmRule_
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/lts" -v -coverprofile="./huaweicloud/services/acceptance/lts/lts_coverage.cov" -coverpkg="./huaweicloud/services/lts" -run TestAccKeywordsAlarmRule_ -timeout 360m -parallel 10
=== RUN   TestAccKeywordsAlarmRule_basic
=== PAUSE TestAccKeywordsAlarmRule_basic
=== CONT  TestAccKeywordsAlarmRule_basic
--- PASS: TestAccKeywordsAlarmRule_basic (75.84s)
PASS
coverage: 13.0% of statements in ./huaweicloud/services/lts
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/lts       76.005s coverage: 13.0% of statements in ./huaweicloud/services/lts
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      image

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@wuzhuanhong wuzhuanhong force-pushed the lts_sql_alarm branch 3 times, most recently from ea2faee to 9bc6ca6 Compare April 21, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant