Skip to content

feat(er): supports new resource to update the attachment infos #6734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Lance52259
Copy link
Contributor

What this PR does / why we need it:
Add new resource to do attachment update operation.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1. Supports new resource to update the attachment infos.

PR Checklist

  • Tests added/passed.
./scripts/coverage.sh -o er -f TestAccAttachmentUpdate_basic
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/er" -v -coverprofile="./huaweicloud/services/acceptance/er/er_coverage.cov" -coverpkg="./huaweicloud/services/er" -run TestAccAttachmentUpdate_basic -timeout 360m -parallel 10
=== RUN   TestAccAttachmentUpdate_basic
=== PAUSE TestAccAttachmentUpdate_basic
=== CONT  TestAccAttachmentUpdate_basic
--- PASS: TestAccAttachmentUpdate_basic (123.58s)
PASS
coverage: 15.5% of statements in ./huaweicloud/services/er
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/er        123.698s        coverage: 15.5% of statements in ./huaweicloud/services/er
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      image

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @Lance52259

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants