Conversation
c3c062d to
21b2048
Compare
Contributor
Author
|
the test with Node 4 fails because npm errors if peerDependencies are not fulfilled while npm 3+ only shows a warning. I suggest we add "peerDependencies": {
"hubot": ">=2 <10 || 0.0.0-development"
},I tested it locally and it worked. I’ll update the evolution process and the PRs that I already sent to the scripts |
gr2m
added a commit
to gr2m/hubot-heroku-keepalive
that referenced
this pull request
Jun 27, 2017
gr2m
added a commit
to gr2m/hubot-google-images
that referenced
this pull request
Jun 27, 2017
gr2m
added a commit
to gr2m/hubot-google-translate
that referenced
this pull request
Jun 27, 2017
gr2m
added a commit
to gr2m/hubot-pugme
that referenced
this pull request
Jun 27, 2017
gr2m
added a commit
to hubotio/hubot-redis-brain
that referenced
this pull request
Jun 27, 2017
gr2m
added a commit
to gr2m/hubot-shipit
that referenced
this pull request
Jun 27, 2017
Member
technicalpickles
left a comment
There was a problem hiding this comment.
Was it intentional to remove the CHANGELOG.md? Should we keep that around for things before semantic-release is used?
Contributor
Author
|
@technicalpickles we will add a link to the last version of the |
21b2048 to
6475fc8
Compare
BREAKING CHANGE: node@0.10 and node@0.12 are no longer supported BREAKING CHANGE: Deep requires like `require(hubot/src/adapter)` are no longer supported, use `require(hubot).Adapter` instead. BREAKING CHANGE: `Middleware.ticker()` has been removed. Use `process.nextTick()` instead.
Contributor
Author
|
@technicalpickles alternatively we could create releases for past versions and put the changes in each release note, would you like me to do that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see
semantic-releaseto Hubot 🤖 evolution#6for a release to happen, we have to add another commit which can be done using
--allow-empty.hubot@3comes with a new feature and 3 breaking changes. The commit can look as follows: