fix: robot.logger getting called prior to the Shell adapter loading #1807
+60
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where robot.logger methods would fail if called before the Shell adapter's run() method initializes the readline interface. The fix moves the logger method overrides from the constructor to the run() method, after the readline interface is created.
Key changes:
- Moved logger method setup from constructor to
run()method in Shell adapter - Converted local variables to private class fields for log levels and priorities
- Added test case to verify logging works before adapter initialization
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/adapters/Shell.mjs | Refactored logger setup to occur in run() method after readline initialization; converted logger configuration variables to private fields |
| test/Shell_test.mjs | Added test case to verify logging before adapter initialization doesn't throw errors |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🎉 This PR is included in version 13.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.