Skip to content

feat: fix shell logger takeover when robot.logger is called before run #1808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joeyguerra merged 6 commits into from
Dec 31, 2025
+7 −7
Merged

feat: fix shell logger takeover when robot.logger is called before run #1808

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6cf7182
fix: robot.logger getting called prior to the Shell adapter loading
joeyguerra Dec 31, 2025
f29c1e5
Update src/adapters/Shell.mjs
joeyguerra Dec 31, 2025
1557fdf
implement co-pilot suggestions
joeyguerra Dec 31, 2025
abbf851
Merge branch 'logger-fix' of github.com:hubotio/hubot into logger-fix
joeyguerra Dec 31, 2025
4f05653
trailing spaces
joeyguerra Dec 31, 2025
a949263
fix issue
joeyguerra Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions test/Shell_test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ describe('Shell Adapter: Logger before adapter run', () => {
const robot = new Robot('Shell', false, 'TestHubot')
robot.stdin = new stream.Readable()
robot.stdin._read = () => {}

const originalLog = console.log
const logMessages = []
console.log = (...args) => {
Expand All @@ -245,20 +245,20 @@ describe('Shell Adapter: Logger before adapter run', () => {
await assert.doesNotReject(async () => {
// Before loadAdapter - uses default pino logger
robot.logger.info('log before adapter load')

await robot.loadAdapter()

// After loadAdapter but before run - still uses pino logger (logger override happens in run())
await robot.logger.info('log after load before run')

await robot.run()

// After run - uses Shell adapter's custom logger with formatted output
await robot.logger.info('log after run')
})

// Verify that logging after run() uses the Shell adapter's custom formatted logger
assert.ok(logMessages.some(msg => typeof msg === 'string' && msg.includes('[info]') && msg.includes('log after run')),
assert.ok(logMessages.some(msg => typeof msg === 'string' && msg.includes('[info]') && msg.includes('log after run')),
'Should use Shell adapter formatted logger after run()')
} finally {
console.log = originalLog
Expand Down