Skip to content

Unpin huggingface_hub in HF sandbox examples #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
burtenshaw merged 2 commits into from
Jul 3, 2026
Merged

Unpin huggingface_hub in HF sandbox examples #913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3094333
Unpin huggingface_hub in HF sandbox examples now that SandboxPool shi…
sergiopaniego Jul 3, 2026
a39bb81
Merge branch 'main' into unpin-hf-sandbox-examples
burtenshaw Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/browsergym_trl_hf_sandbox.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
# "trl[vllm,peft]",
# "trackio",
# "kernels",
# "huggingface_hub @ git+https://github.com/huggingface/huggingface_hub.git@5b643062ac4efa4d940d7d614a4dfc8ccaf910b5",
# "huggingface_hub>=1.22.0",
# "transformers>=5.0.0",
# ]
# ///
Expand Down
2 changes: 1 addition & 1 deletion examples/hf_sandbox_coding_env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

# /// script
# dependencies = [
# "huggingface_hub @ git+https://github.com/huggingface/huggingface_hub.git@5b643062ac4efa4d940d7d614a4dfc8ccaf910b5",
# "huggingface_hub>=1.22.0",

@cursor cursor Bot Jul 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified ✅ — I installed the released huggingface_hub==1.22.0 and confirmed from huggingface_hub import SandboxPool resolves, plus Sandbox.proxy_url_for / Sandbox.proxy_headers and SandboxPool.create, which is exactly what HFSandboxProvider uses. This >=1.22.0 floor is correct and sufficient, and it drops the unpinned git-commit install. Same change applies to examples/browsergym_trl_hf_sandbox.py:21.

# ]
# ///

Expand Down
Loading