CLI: gate pushes on staged remote validation#957
Draft
zkwentz wants to merge 1 commit into
Draft
Conversation
This was referenced Jul 12, 2026
b96fbbc to
4ac290c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & Why
openenv pushmust not validate one tree and upload another. This PR prepares the exact Space snapshot, validates that snapshot remotely with the strict publish profile, binds the report digest, and uploads the portable author report with the same revision.Risk & Review Guidance
src/openenv/cli/commands/push.py:342for digest binding;src/openenv/cli/commands/push.py:394for staging/filtering;src/openenv/cli/commands/push.py:622for upload orderingDecisions & Alternatives
.venv/hidden paths — prevents path escape without breaking common local setups..openenv/validation-report.jsonafter validation — the report is portable, versioned, and explicitly uncertified.Verification
PYTHONPATH=src:envs .venv/bin/python -m pytest tests/test_cli/test_push.py tests/test_validation/test_remote.py -q— 70 passed after the final symlink-filter refinement.PYTHONPATH=src:envs .venv/bin/python -m pytest tests/ -q -m 'not integration'— 1,559 passed, 114 skipped, 31 external integration tests deselected on the complete stack.Scope & Non-Goals
Breaking Changes / Migration Notes
Hub pushes now require HF authentication capable of creating a dedicated Sandbox and a fully passing publish profile. Custom registry pushes now require the local strict profile.
Stack
PR 16 of 17; depends on #956.
Full 17-PR stack
All upstream PRs remain draft while RFC 008 is under review.