Security: Fix unsafe torch.load in FSDP2 scaler path (#3964)#3966
Open
davidequarracino wants to merge 3 commits intohuggingface:mainfrom
Open
Security: Fix unsafe torch.load in FSDP2 scaler path (#3964)#3966davidequarracino wants to merge 3 commits intohuggingface:mainfrom
davidequarracino wants to merge 3 commits intohuggingface:mainfrom
Conversation
This tutorial implements Method 2 by demonstrating how to gather predictions into an external list using gather_object and .extend() within notebook_launcher.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security fix for #3964 (CWE-502). Added weights_only=True to torch.load in FSDP2 scaler path (line 3811) to prevent arbitrary code execution. This PR was split to prioritize safety.