fix: pass step parameter in TrackioTracker.log()#3970
Open
liuyun7345 wants to merge 1 commit intohuggingface:mainfrom
Open
fix: pass step parameter in TrackioTracker.log()#3970liuyun7345 wants to merge 1 commit intohuggingface:mainfrom
liuyun7345 wants to merge 1 commit intohuggingface:mainfrom
Conversation
TrackioTracker.log() accepts a step parameter but never forwards it to self.run.log(), causing step values to be silently auto-incremented instead of using the user-provided values. All other trackers (WandB, TensorBoard, CometML, Aim, MLflow, SwanLab) correctly pass step=step. This was simply missed when TrackioTracker was added. Fixes huggingface#3963 Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
TrackioTracker.log()accepts astepparameter but never forwards it toself.run.log(), causing step values to be silently auto-incremented instead of using the user-provided values.All other trackers (WandB, TensorBoard, CometML, Aim, MLflow, SwanLab) correctly pass
step=stepto their respective logging backends. This was simply missed whenTrackioTrackerwas added.Fix
One-line change: pass
step=steptoself.run.log()inTrackioTracker.log().Before submitting
Fixes #3963