fix: add DefaultLoadPlanner to FSDP2 + SHARDED_STATE_DICT optimizer checkpoint loading#3972
Open
iavinas wants to merge 1 commit intohuggingface:mainfrom
Open
fix: add DefaultLoadPlanner to FSDP2 + SHARDED_STATE_DICT optimizer checkpoint loading#3972iavinas wants to merge 1 commit intohuggingface:mainfrom
iavinas wants to merge 1 commit intohuggingface:mainfrom
Conversation
Without the planner, dist_cp.load() cannot resolve nested optimizer state keys (e.g. optimizer.state.0.step), causing a RuntimeError on checkpoint load with SHARDED_STATE_DICT + fsdp_version 2.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the planner, dist_cp.load() cannot resolve nested optimizer state keys (e.g. optimizer.state.0.step), causing a RuntimeError on checkpoint load with SHARDED_STATE_DICT + fsdp_version 2.
What does this PR do?
Fixes # (issue) #3971
DefaultLoadPlanner()todist_cp.load()inload_fsdp_optimizer, matching theDefaultSavePlanner()already used on the save sideTest plan
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.