VarMap Overhaul: Mutex/RwLock Backends, Unified Interface, and Concurrency Support #3027
+1,776
−36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a unified and extensible interface and serialization format.
Key updates:
Adds ConcurrentVarMap (RwLock-based) for high-performance, concurrent inference.
Refactors VarMap to use a generic storage backend, preserving the original Mutex-based behavior for training.
Ensures full compatibility between old and new APIs, including save/load and variable initialization.
Comprehensive tests for compatibility, integration, and concurrent stress scenarios.
These changes make it easier to scale Candle models for both training and production inference, while keeping the API simple and backward-compatible.