eliminate build dependency on installed protoc, re-export prost::Message #3086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To decode a model into ModelProto you need to have the prost::Message trait in scope. If you depend on a different version of prost then candle decoding will fail. By re-exporting prost users can depend directly on our version.
dvdsk
changed the title
|
Unfortunately this does not work on all platforms (breaking on mac & windows). How do you all feel about shipping pre-'compiled' protocol buffers? That should help compile time & get rid of the dependency on protoc? |
dvdsk
force-pushed
the
re-export-prost
branch
from
e4f10bb to
eb98741
Compare
Not opposed at all actually. With the change I'd like a github action that ensures correctness though :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses protobuf-src to build statically linked protoc from scratch. This removes the requirement to have protoc installed (which quickly gets annoying when building for N different platforms).
To decode a model into ModelProto you need to have the prost::Message trait in scope. If you depend on a different version of prost then candle decoding will fail. By re-exporting prost users can depend directly on our version.