Update cargo build instructions to use double colon syntax #3132
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #3104 (comment)
Use
cargo::syntax for build instructions per https://doc.rust-lang.org/cargo/reference/build-scripts.html#outputs-of-the-build-script.Notes
cargo:build commands withcargo::.candle-examples/*passes$ cargo checkcandle-flash-attnandcandle-kernelsseem to rely on having NVIDIA drivers installed, so I couldn't run$ cargo check(I use a m4 macbook)Questions
cargo::infobuild command used (and passes check incandle-examples) but couldn't find reference to it in the docs. When I tried updating the bert binary example to use it instead ofcargo::warnthat seemed to fail. Shouldcargo::infobe used instead ofcargo::warnin the bert binary builder?candle-flash-attnandcandle-kernelson my mac, but CI should ensure I didn't break anything build wise for CUDA - is that right?