Fix Metal matmul failure in ModernBertHead::forward by ensuring contiguous input
#3139
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On Apple Metal,
ModernBertHead::forwardmay receive a non-contiguous view from upstream pooling (CLS/MEAN). Passing that view directly intoLinearcauses the Metal matmul path to misinterpret shapes and fail with:CPU succeeds because it tolerates non-contiguous inputs. We materialize the input with
contiguous()before applyingLinear. This resolves the Metal-only failure and aligns with prior guidance that GPU matmul expects contiguous tensors. ([GitHub][1])Patch
impl Module for ModernBertHead { fn forward(&self, xs: &Tensor) -> Result<Tensor> { - let xs = xs.apply(&self.dense)?.gelu_erf()?.apply(&self.norm)?; + let xs = xs.contiguous()?.apply(&self.dense)?.gelu_erf()?.apply(&self.norm)?; Ok(xs) } }Issue
#3138 (comment)