Add nll_with_ignore and cross_entropy_with_ignore
#3161
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds
ignore_indexsupport to cross-entropy and NLL loss functions via new*_with_ignorefunctions, enabling proper handling of padding tokens in sequence modeling.Motivation
Sequence modeling (NLP, time series) requires excluding padding tokens from loss computation. Currently users must manually mask losses, which is error-prone and less efficient.
Changes
loss::nll_with_ignore(inp, target, ignore_index)functionloss::cross_entropy_with_ignore(inp, target, ignore_index)functionPyTorch Compatibility
Matches PyTorch functionality with two documented divergences:
0.0(PyTorch returnsnan) for better ergonomicsu32(PyTorch usesi32) to match Candle's target dtypeOpen Questions