replace cutlass submodule references with explicit build step #3234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this has the benefit of not weighing down CI builds on non-CUDA platforms, and also enables shallow clone to make builds on CUDA platforms lighter weight. The cutlass checkout alone is 210MiB, which this commit saves on platforms that don't need it. I don't have a modern enough CUDA GPU available to run with flash-attention, but I have tested on older CUDA machine as well as on MacOS, and modulo the asserts for the NVIDIA hardware version, the build completes as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this has the benefit of not weighing down CI builds on non-CUDA platforms, and also enables shallow clone to make builds on CUDA platforms lighter weight. The cutlass checkout alone is 210MiB, which this commit saves on platforms that don't need it.
I don't have a modern enough CUDA GPU available to run with flash-attention, but I have tested on older CUDA machine as well as on MacOS, and modulo the asserts for the NVIDIA hardware version, the build completes as expected.