Skip to content

fix: update depricated langchain imports - #346

Merged
stevhliu merged 3 commits into
huggingface:mainfrom
Spartan-71:main
Mar 18, 2026
Merged

fix: update depricated langchain imports#346
stevhliu merged 3 commits into
huggingface:mainfrom
Spartan-71:main

Conversation

@Spartan-71

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes broken imports in the rag_zephyr_langchain notebook caused by breaking changes in the LangChain API upgrade. Updates deprecated import paths to match the current LangChain package structure.

Fixes # (issue)

Who can review?

@merveenoyan @stevhliu

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@stevhliu stevhliu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks for updating!

@@ -42,7 +42,7 @@
},

@stevhliu stevhliu Mar 18, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #2.    print(result)

lets not print the result here or the output below as that is breaking the doc-builder


Reply via ReviewNB

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okk. done

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think showing the output here is still breaking the doc-builder. lets remove that entirely

@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@stevhliu
stevhliu merged commit ed2c646 into huggingface:main Mar 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants