Skip to content

Translate Romanian Chapter 1 #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 57 commits into
base: main
Choose a base branch
from

Conversation

eduard-balamatiuc
Copy link
Contributor

This is the romanian translation of chapter 1.
Ping @lewtun and @stevhliu for a review

Also ping @hbkdesign as discussed here as a native speaker who could help us review the text.

ludmila.friptu and others added 30 commits September 28, 2024 20:30
Co-authored-by: Eduard Balamatiuc <[email protected]>
Co-authored-by: Eduard Balamatiuc <[email protected]>
Co-authored-by: Eduard Balamatiuc <[email protected]>
Co-authored-by: Eduard Balamatiuc <[email protected]>
Co-authored-by: Eduard Balamatiuc <[email protected]>
Co-authored-by: Eduard Balamatiuc <[email protected]>
Co-authored-by: Eduard Balamatiuc <[email protected]>
Co-authored-by: Eduard Balamatiuc <[email protected]>
Co-authored-by: Eduard Balamatiuc <[email protected]>
Co-authored-by: Eduard Balamatiuc <[email protected]>
Co-authored-by: Eduard Balamatiuc <[email protected]>
Co-authored-by: Eduard Balamatiuc <[email protected]>
Co-authored-by: Eduard Balamatiuc <[email protected]>
Co-authored-by: Eduard Balamatiuc <[email protected]>
Co-authored-by: Eduard Balamatiuc <[email protected]>
Co-authored-by: Eduard Balamatiuc <[email protected]>
Co-authored-by: Eduard Balamatiuc <[email protected]>
Co-authored-by: Eduard Balamatiuc <[email protected]>
Co-authored-by: Eduard Balamatiuc <[email protected]>
Co-authored-by: Eduard Balamatiuc <[email protected]>
Co-authored-by: Eduard Balamatiuc <[email protected]>
Co-authored-by: Eduard Balamatiuc <[email protected]>
Co-authored-by: Eduard Balamatiuc <[email protected]>
Co-authored-by: Eduard Balamatiuc <[email protected]>
Co-authored-by: Eduard Balamatiuc <[email protected]>
Co-authored-by: Eduard Balamatiuc <[email protected]>
Copy link

@hbkdesign hbkdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve completed my review of the Romanian translation for chapter1/2.mdx. I suggested a few refinements to improve fluency, remove repetitions, and clarify some technical terms . Overall, a solid and accurate translation - great work!

I will proceed to reviewing the next chapter.

Copy link

@hbkdesign hbkdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished reviewing the Romanian translation of chapter1/3.mdx.
I suggested several improvements focused on grammar, tone, and fluency — including adjective-noun agreement (e.g., “puternic”), replacing overly casual expressions like “să vă jucați” with more natural alternatives like “să explorați” or “să interacționați”, and correcting verb usage such as “să nu trebuie” → “să nu fie nevoie”.
Overall, the translation is strong and educational — great work!

Copy link

@hbkdesign hbkdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished reviewing the Romanian translation for chapter1/4.mdx.
I suggested improvements to grammar, fluency, and terminology,
and clearer phrasing for concepts like transfer learning and fine-tuning.
Great work on this translation - it's well-structured and informative!

Copy link

@hbkdesign hbkdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve reviewed the Romanian translation for chapter1/5.mdx and found it to be clear, accurate, and well-written. I have no suggestions - everything looks great as is.

Copy link

@hbkdesign hbkdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve reviewed the Romanian translation for chapter1/6.mdx and found it to be clear, accurate, and well-written. I have no suggestions - everything looks great.

Copy link

@hbkdesign hbkdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve reviewed the Romanian translation for chapter1/7.mdx and found it to be clear, accurate, and well-written. I have no suggestions — everything looks great

Copy link

@hbkdesign hbkdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished reviewing chapter1/8.mdx.
I suggested improvements related to fluency, tone, and clarity — including smoother phrasing like “este important să conștientizați că...” instead of “trebuie să aveți în minte faptul că...” and replacing “nu va face ca această prejudecată... să dispară” with a more natural version.
This chapter communicates essential ethical considerations very clearly. Great job overall!

Copy link

@hbkdesign hbkdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished reviewing the Romanian translation of chapter1/9.mdx.
I suggested a few improvements related to grammar, fluency, and technical terminology. These included corrections like “importanța la” --> “importanța transfer learning-ului”, replacing “encoder-ul”/“decoder-ul” with “encoderul”/“decoderul”, and refining the tone in expressions like “la un nivel general”.
The content is well-structured and communicates key architectural insights effectively great job!

Copy link

@hbkdesign hbkdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes are needed.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@stevhliu
Copy link
Member

Thank you so much for your detailed review @hbkdesign! 👏

Let me know when this PR is ready to merge :)

@burtenshaw burtenshaw self-requested a review April 17, 2025 14:03
@burtenshaw
Copy link
Collaborator

Nice work @eduard-balamatiuc and @hbkdesign. I'm here too if you need.

@eduard-balamatiuc
Copy link
Contributor Author

Hey @stevhliu sorry for the delay, I doubled checked on my side, and I think the PR is ready to be merged from the translation side.

Only one additional note, I was not able to run the doc-builder with the currently available pypi version, and I had to use the separate github repository directly to install the library from there, here is the repo, this allowed me to see everything as per the below image
image
The only additional question from my side would be about this PR live, for some reason I get a 404 error, might it be because the environment also uses the pypi version of doc builder, is there something needed from my side if this is the problem, or can we already merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants