Skip to content

no cache push#39

Open
EziOzoani wants to merge 5 commits intomainfrom
main_UI_updates
Open

no cache push#39
EziOzoani wants to merge 5 commits intomainfrom
main_UI_updates

Conversation

@EziOzoani
Copy link
Copy Markdown

Updated files:

  • app.py
  • dataset_util.py

new files:

  • styles.css and index.html: stylisation code for streamlit's component

app.py Outdated

With this tool, you can:

✓ Dynamic loading of datasets in the lib
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These checks look different than in the design, where instead they have a circle around them. Is it possible to make those instead?

}
span .number-label {
padding: 8px 12px;
background-color: #dddddd;
Copy link
Copy Markdown
Collaborator

@meg-huggingface meg-huggingface Oct 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this #dddddd is creating a grey everywhere between the tabs and below, which is looking messy. Can it be closer to the design, which seems to just be white?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2022-10-25 at 10 21 06 AM

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May also be the one on line 57.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, I'm not positive if it would be here, but if we're going to use a background color please also adding padding on the right and left of the text (especially the tab text) so the text is not hitting the border. However, if the grey is removed, and it's white instead, you won't see a border, so it won't be necessary.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it should be fixed now

Copy link
Copy Markdown
Collaborator

@meg-huggingface meg-huggingface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting there!! I'm also noticing that "Text Lengths" and "Text Distributions" aren't showing up properly, but that might be something that's an issue on the main branch as well -- I'll check it out and let you know if there's any issue for that here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants