refactor(libcommon): remove old parquet indexer#3266
Closed
kszucs wants to merge 27 commits intohuggingface:mainfrom
Closed
refactor(libcommon): remove old parquet indexer#3266kszucs wants to merge 27 commits intohuggingface:mainfrom
kszucs wants to merge 27 commits intohuggingface:mainfrom
Conversation
kszucs
commented
Nov 25, 2025
Member
Author
There was a problem hiding this comment.
Only changed by ruff format.
kszucs
force-pushed
the
remove-old-index
branch
4 times, most recently
from
9f5ce69 to
3e6fbd7
Compare
…ude it during docker install
kszucs
force-pushed
the
remove-old-index
branch
from
8c95106 to
f65d55e
Compare
kszucs
force-pushed
the
remove-old-index
branch
from
73578df to
0cc38ac
Compare
kszucs
force-pushed
the
remove-old-index
branch
from
64b79ae to
8825f39
Compare
kszucs
force-pushed
the
remove-old-index
branch
from
46a16b8 to
10916d6
Compare
Member
Author
|
Reopened it from an upstream branch #3269 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new libviewer is capable of pruning parquet data pages reducing the required scan size, so make libviewer a mandatory dependency of libcommon and remove the old pyarrow based row-group pruning reader.