Skip to content

Add try_original_type to DatasetDict.map #7544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add try_original_type to DatasetDict.map #7544

wants to merge 3 commits into from
+37 −4

Conversation

yoshitomo-matsubara
Copy link
Contributor

This PR resolves #7472 for DatasetDict

The previously merged PR #7483 added try_original_type to ArrowDataset, but DatasetDict misses try_original_type

Cc: @lhoestq

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

lhoestq
lhoestq reviewed Apr 29, 2025
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! can you run make style to fix code formatting before we merge ?

@yoshitomo-matsubara
Copy link
Contributor Author

Sure! I just committed the changes

@yoshitomo-matsubara
Copy link
Contributor Author

@lhoestq
Let me know if there are other things to do before merge or other places to add try_original_type argument

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhoestq lhoestq lhoestq left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Label casting during map process is canceled after the map process
3 participants
@yoshitomo-matsubara @HuggingFaceDocBuilderDev @lhoestq