Fix duplicate kwargs in load_dataset_builder#7974
Open
KOKOSde wants to merge 1 commit intohuggingface:mainfrom
Open
Fix duplicate kwargs in load_dataset_builder#7974KOKOSde wants to merge 1 commit intohuggingface:mainfrom
KOKOSde wants to merge 1 commit intohuggingface:mainfrom
Conversation
KOKOSde
force-pushed
the
fix/duplicate-builder-kwargs
branch
from
c5675df to
a07da30
Compare
Avoid TypeError when builder_kwargs and config_kwargs share keys like base_path. Fixes huggingface#4910
KOKOSde
force-pushed
the
fix/duplicate-builder-kwargs
branch
from
a07da30 to
e6fc266
Compare
Contributor
Author
|
Quick ping on this one. Happy to update anything if you want changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid passing duplicate keyword arguments to
load_dataset_builder.Some module factories provide values in
builder_kwargs(e.g.base_path), and users can also pass the same keys viaconfig_kwargs, which raises:TypeError: ... got multiple values for keyword argument ....Fix: if
config_kwargsis provided, drop overlapping keys frombuilder_kwargs(keep the user-provided values).Includes a regression test.