Fix schema enforcement in streaming _convert_to_arrow#8042
Open
HaukurPall wants to merge 1 commit intohuggingface:mainfrom
Open
Fix schema enforcement in streaming _convert_to_arrow#8042HaukurPall wants to merge 1 commit intohuggingface:mainfrom
HaukurPall wants to merge 1 commit intohuggingface:mainfrom
Conversation
When the iter_arrow chain is broken (e.g. after .map() without
with_format("arrow")), _convert_to_arrow falls back to
pa.Table.from_pylist() which infers types from values. If early
batches contain None or empty lists, Arrow infers null/list<null>
types that conflict with later batches containing real data,
causing ArrowInvalid schema mismatch errors.
Add an optional features parameter to _convert_to_arrow that
applies cast_table_to_features to each produced table, mirroring
what ArrowWriter.write_table does in the map-style path.
HaukurPall
force-pushed
the
fix-convert-to-arrow-schema-enforcement
branch
from
291b12a to
beef56c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the iter_arrow chain is broken (e.g. after .map() without with_format("arrow")), _convert_to_arrow falls back to pa.Table.from_pylist() which infers types from values. If early batches contain None or empty lists, Arrow infers null/list types that conflict with later batches containing real data, causing ArrowInvalid schema mismatch errors.
Add an optional features parameter to _convert_to_arrow that applies cast_table_to_features to each produced table, mirroring what ArrowWriter.write_table does in the map-style path.