Skip to content

fix: mutable default argument in _visit_with_path #8130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stef41 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

fix: mutable default argument in _visit_with_path #8130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/datasets/features/features.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1721,7 +1721,7 @@ def _visit(feature: FeatureType, func: Callable[[FeatureType], Optional[FeatureT


def _visit_with_path(
feature: FeatureType, func: Callable[[FeatureType, _VisitPath], Optional[FeatureType]], visit_path: _VisitPath = []
feature: FeatureType, func: Callable[[FeatureType, _VisitPath], Optional[FeatureType]], visit_path: Optional[_VisitPath] = None
) -> FeatureType:
"""Visit a (possibly nested) feature with its path in the Feature object.

Expand All @@ -1739,6 +1739,8 @@ def _visit_with_path(
Returns:
`FeatureType`: the visited feature.
"""
if visit_path is None:
visit_path = []
if isinstance(feature, Features):
out = func(Features({k: _visit_with_path(f, func, visit_path + [k]) for k, f in feature.items()}), visit_path)
elif isinstance(feature, dict):
Expand Down