Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LoRA] Handle DoRA better #9547

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[LoRA] Handle DoRA better #9547

wants to merge 6 commits into from

Conversation

sayakpaul
Copy link
Member

What does this PR do?

Our support for loading community DoRA checkpoints is currently broken. See KohakuBlueleaf/LyCORIS#216.

So, this PR:

  1. Detects if a state dict has dora_scale present. Upon detection, it logs a warning about the incompatibility and filters the state dict so that it doesn't have the dora_scale keys.
  2. Adjust the tests accordingly.

Once Ben gives a go ahead I will request for a review from Yiyi.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree it's better not to load these DoRA weights, as we now pretty much agree with Kohaku that their DoRA implementation is using the other axis.

Just a nit, the unit test could check for the new warning message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants