Preserve Markdown callout blockquote lines in docbuilder style docstring formatting + merge body#757
Open
qgallouedec wants to merge 8 commits intohuggingface:mainfrom
Open
Preserve Markdown callout blockquote lines in docbuilder style docstring formatting + merge body#757qgallouedec wants to merge 8 commits intohuggingface:mainfrom
qgallouedec wants to merge 8 commits intohuggingface:mainfrom
Conversation
…tring formatting
- Update regex to capture markdown blockquote lines and callout headers. - Implement function to format blockquote text while preserving prefixes. - Modify style_docstring to merge consecutive callout body lines. - Add tests to verify correct formatting and wrapping of blockquote content.
Member
albertvillanova
left a comment
There was a problem hiding this comment.
Are you sure we are keeping the expected behavior as needed in huggingface/trl#5172:
> [!NOTE]
> We want to keep the lists:
> - Item 1
> - Item 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #756, but wraps the text: