fix: fix native TLS option to use the native certificate roots.#137
Open
zicklag wants to merge 1 commit intohuggingface:mainfrom
Open
fix: fix native TLS option to use the native certificate roots.#137zicklag wants to merge 1 commit intohuggingface:mainfrom
zicklag wants to merge 1 commit intohuggingface:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like an update to
ureqrequires you to explicitly state that you want to use the native platform certificate verifier.Personally, as someone operating behind an http proxy with a custom https certificate, that is usually why I'm needing native TLS in the first place, so I think it makes sense to enable by default.
This fixes me being unable to download anything when using libraries like candle because ureq isn't trusting my system's https certificate store.
PS: I thought there was another problem with this when it didn't work to run the example, but apparently the example actually tries to download a file that requires authentication. I did confirm this works by changing the repo + file to something that was public.