fix(xet): implement get_file_chunk_hashes after xet-core trait bump#175
Merged
Conversation
xet-core main added a new `get_file_chunk_hashes` method on the `Client` trait. The release CI re-resolves `branch = main` (not --locked), so it picked up the new trait revision and our `CachedXetClient` failed E0046, blocking the v0.6.4 binary build. Forward the call to `self.inner` (the wrapped client); cache layer only handles reconstruction queries. Updates `MockClient` test shim too and bumps the Cargo.lock pin to the latest xet-core main.
Contributor
POSIX Compliance (pjdfstest) |
Contributor
Benchmark Results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xet-core main added a new
get_file_chunk_hashesmethod on theClienttrait. The release CI re-resolvesbranch = main(not--locked), so it picked up the new trait revision and ourCachedXetClientfailed E0046, blocking the v0.6.4 binary build (see failed run 26251717702).This PR:
get_file_chunk_hashesonCachedXetClientby forwarding toself.inner(cache layer only handles reconstruction queries, not chunk hashes).MockClientshim.Cargo.lockto the latest xet-core main so local builds match CI.Once merged, the v0.6.4 release workflow can be re-run and binaries will publish, unblocking the SkyPilot PR (skypilot-org/skypilot#9418) which needs v0.6.4 for the clone_fd fix.