Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
davanstrien
approved these changes
Mar 27, 2025
Member
davanstrien
left a comment
davanstrien
left a comment
There was a problem hiding this comment.
Had one qs and small suggestions but looks good :)
docs/hub/datasets-image.md
Outdated
| ``` | ||
|
|
||
| Alternatively, Parquet files with Image data can be created using the `datasets` library by setting the column type to `Image()` and using the `.to_parquet(...)` method or `.push_to_hub(...)`. You can find a guide on loading image datasets in `datasets` [here](/docs/datasets/image_load). | ||
| Note that Parquet is recommended for small images (<1MB per image) and small row groups (100 rows per row group, which is what `datasets` uses for images). For larger images it is recommended to use the WebDataset format, or to share the original image files (optionally with metadata files). |
Member
There was a problem hiding this comment.
Just to clarify, does the guidance here say that parquet makes sense only if you have small images AND small row groups? I suspect more people will default to original image files so maybe we also need to point to the repository limits page too in that case?
Member
Author
There was a problem hiding this comment.
yup correct, I'll add a link to the repo limits
julien-c
approved these changes
Mar 28, 2025
Co-authored-by: Daniel van Strien <davanstrien@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
more docs for image/audio/webdataset