Conversation
julien-c
requested review from
Wauplin,
davanstrien,
hanouticelina and
rajatarya
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
rajatarya
left a comment
rajatarya
left a comment
There was a problem hiding this comment.
Love it, my comments are to make sure users still install git-lfs as it is still required.
@seanses - did we make git-lfs a dependency to git-xet? Meaning, do users still have to install git-lfs prior to git-xet - or can they simply install git-xet and git-lfs will get installed for them?
docs/hub/datasets-downloading.md
Outdated
|
|
||
| ```bash | ||
| git lfs install | ||
| git-xet install |
There was a problem hiding this comment.
So we need to make sure git-lfs is installed along with git-xet, right now.
I think we should write it as:
git lfs install
git-xet install
git clone ...
(To remove the requirement for git-lfs is a big change and one we are looking to write up a plan for by end of year, and then ask for priority clarification - how imporatant is xet v2 vs other projects.)
There was a problem hiding this comment.
I think we can also have this written as:
git xet install
(once git-xet is installed into the PATH, then git will always look for a binary in the path with the name git-<cmd> when running git cmd.)
There was a problem hiding this comment.
wondering if git xet install could also call git lfs install under the hood? so DX is as simple as possible
docs/hub/models-downloading.md
Outdated
|
|
||
| ```bash | ||
| git lfs install | ||
| git-xet install |
There was a problem hiding this comment.
Same here:
git xet install
git lfs install
git clone ...
| This document shows how to handle repositories through the web interface as well as through the terminal. There are no requirements if working with the UI. If you want to work with the terminal, please follow these installation instructions. | ||
|
|
||
| If you do not have `git` available as a CLI command yet, you will need to [install Git](https://git-scm.com/downloads) for your platform. You will also need to [install Git LFS](https://git-lfs.github.com/), which will be used to handle large files such as images and model weights. | ||
| If you do not have `git` available as a CLI command yet, you will need to [install Git](https://git-scm.com/downloads) for your platform. You will also need to [install Git-xet](./xet/using-xet-storage#git-xet), which will be used to handle large files such as images and model weights. |
There was a problem hiding this comment.
"You will also need to install Git LFS and to install Git-xet, which will be used to handle large files such as images and model weights."
We still need git-lfs installed along with git-xet.
|
|
||
| ```bash | ||
| git lfs install | ||
| git-xet install |
@rajatarya No, our installation scripts doesn't check git-lfs right now, but I think we can make them do. |
that'd be awesome! BTW, please also check internal companion PR |
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
|
Ok merging this, feel free to open follow-on edits or improvements! |
7 participants
No description provided.